Add helpers for authenticated media, and associated documentation #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
the
T-Enhancement
4 tasks
turt2live
commented
Apr 30, 2024
| @@ -21,6 +21,10 @@ endpoints from before Matrix 1.1, for example. | |||
|
|
|||
| # Quickstart | |||
|
|
|||
| > [!IMPORTANT] | |||
There was a problem hiding this comment.
for the reviewer - I think this our first usage of the blockquote styles provided by github. See https://github.com/orgs/community/discussions/16925 for details.
dbkr
reviewed
May 1, 2024
|
Ah, sorry, it's mentioned briefly in the README diff here and in the depths of element-hq/element-web#27326 (comment) somewhere - we'd be introducing a breaking change later (once the MSC is either stable or released) which only returns authenticated media URLs. I'm not sure there's much of a way to avoid a breaking change here, given we'd want the js-sdk to produce authentication-required URLs by default as soon as it possibly can. |
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
May 1, 2024
|
Fair enough, as long as there's a plan for managing the second transition (ie. to stable) as well. |
dbkr
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.