Remove testUtils.failTest #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated replacement of utils.failTest with nodeify
This was done with the perl incantation:
```
find spec -name '*.js' |
xargs perl -i -pe 's/catch\((testUtils|utils).failTest\).done\(done\)/nodeify(done)/'
```
more auto
manual replacement of some more complicated utils.failTest usages with q.all() invocations.
this is no longer used, so kill it
richvdh
force-pushed
the
rav/kill_failTest
branch
from
35b9218
to
8955d8d
Compare
These tests which return a promise already don't need to call `done`.
dbkr
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a helper function I wrote for testing asynchronous tests before I knew better. It turns out there are better ways of doing what it did badly:
nodeifyto turn promise results into nodejs-style callbacks, which is whatdonewantsfailTestobfuscates the actual source of the failure, so let's kill it off.