New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-dup code: use the initialiseState function #611
Merged
Merged
Commits on Feb 16, 2018
-
De-dup code: use the initialiseState function
This should behave identically, but the code here appeared to be identical to the code in initialiseState, so let's use it (it also has an extra sanity check in there that we only init empty timelines).
Configuration menu - View commit details
-
Copy full SHA for 275eb8d - Browse repository at this point
Copy the full SHA 275eb8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c02e7b - Browse repository at this point
Copy the full SHA 8c02e7bView commit details -
Process state events before timeline events
Don't ignore them: its valid to send them in a non-limited sync, they're state events that preceed the timeline events.
Configuration menu - View commit details
-
Copy full SHA for b11bacc - Browse repository at this point
Copy the full SHA b11baccView commit details
Commits on Feb 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 21a3245 - Browse repository at this point
Copy the full SHA 21a3245View commit details -
Configuration menu - View commit details
-
Copy full SHA for c77277b - Browse repository at this point
Copy the full SHA c77277bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a08194 - Browse repository at this point
Copy the full SHA 9a08194View commit details
Commits on Feb 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e810ee7 - Browse repository at this point
Copy the full SHA e810ee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aa68b3 - Browse repository at this point
Copy the full SHA 8aa68b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ddf7fb - Browse repository at this point
Copy the full SHA 1ddf7fbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.