Change initial key backup to background #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
force-pushed
the
slow-key-backup
branch
from
adb5f5b
to
90ff25c
Compare
This will be used in the React SDK to display upload progress when there are many sessions to upload.
This ensures a partially completed backup will continue to make progress.
Alters the APIs used for initial key backup so that the actual upload happens in the background after all session are marked for backup.
jryans
force-pushed
the
slow-key-backup
branch
from
90ff25c
to
0202a9d
Compare
dbkr
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alters the APIs used for initial key backup so that the actual upload happens in
the background after all session are marked for backup.
In addition, this also emits a counts of sessions remaining to backup to drive an upload progress UI.
Needed for element-hq/element-web#7863.
Used in matrix-org/matrix-react-sdk#2416.