Supporting infrastructure for educated decisions on when to upgrade rooms #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
reviewed
Jan 29, 2019
| @@ -31,7 +31,7 @@ const EventTimelineSet = require("./event-timeline-set"); | |||
|
|
|||
| import ReEmitter from '../ReEmitter'; | |||
|
|
|||
| const LATEST_ROOM_VERSION = '1'; | |||
| const KNOWN_SAFE_ROOM_VERSION = '1'; | |||
| const SAFE_ROOM_VERSIONS = ['1', '2']; | |||
There was a problem hiding this comment.
A comment on how SAFE_ROOM_VERSIONS and KNOWN_SAFE_ROOM_VERSION feels like it might be useful
|
The CI builds have been stuck at "Job Received" for nearly 45 minutes now, even after cancelling and restarting. I'm going to assume that adding a comment won't be the end of the world and am merging. |
turt2live
added a commit
to matrix-org/matrix-spec-proposals
that referenced
this pull request
Jan 31, 2019
Original proposals: * #1753 * #1804 Implementation proof: * matrix-org/synapse#4472 * matrix-org/matrix-js-sdk#830 There is one change to MSC1753 which is included in this commit. MSC1804 remains unchanged. In the original proposal, the change password capability being present was an indication that password changes were possible. It was found that this doesn't really communicate the state very well to clients in that lack of a capability (or a 404, etc) would mean that users would erroneously not be able to change their passwords. A simple boolean flag was added to assist clients in detecting this capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#8251
Endpoint requires matrix-org/synapse#4472
Please review with matrix-org/matrix-react-sdk#2518