Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend loglevel logging for the whole project #924

Merged
merged 6 commits into from May 30, 2019
Merged

Extend loglevel logging for the whole project #924

merged 6 commits into from May 30, 2019

Conversation

jkasun
Copy link
Contributor

@jkasun jkasun commented May 19, 2019

Now logging using the loglevel is extend to the whole project instead of console.log
Fixes #772

Signed-off-by: Janith Kasun janithisipathana@gmail.com

@jkasun jkasun changed the title Console logging to loglevel Extend loglevel logging for the whole project May 19, 2019
@turt2live turt2live requested a review from a team May 19, 2019 06:17
turt2live
turt2live requested changes May 24, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! It largely looks okay - there's just a few spots which need some attention. It also looks like there's a merge conflict to resolve, sorry

spec/olm-loader.js Show resolved Hide resolved
src/models/room.js Outdated Show resolved Hide resolved
src/realtime-callbacks.js Outdated Show resolved Hide resolved
@jkasun
Copy link
Contributor Author

jkasun commented May 24, 2019

thanks for the review @turt2live. I'll fix these issues and push another commit.

turt2live
turt2live approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better - thank you! Will try merging it and see what breaks.

@turt2live turt2live merged commit a0456dc into matrix-org:develop May 30, 2019
jryans added a commit that referenced this pull request Jun 27, 2019
@jryans
Fix logging typo
5a64c29 
Regression from #924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees

@jkasun jkasun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend logging to whole project
2 participants
@jkasun @turt2live