Emit an event when a local-echo is turned into a proper event #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to trigger an update of the timeline when this happens, so raise an event for it.
| /** | ||
| * Fires when a local-echo of a transmitted event is replaced by its remote-echo. | ||
| * | ||
| * <p>When an event is first transmitted, then (assuming the /send completes |
There was a problem hiding this comment.
Do your p tags need to be closed here?
There was a problem hiding this comment.
empirically not, and we don't seem to have been closing them in general in the js-sdk doc-comments.
|
otherwise lgtm |
richvdh
added a commit
that referenced
this pull request
Mar 8, 2016
Emit an event when a local-echo is turned into a proper event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to trigger an update of the timeline when this happens, so raise an
event for it.