Skip to content

Commit

Permalink
Remove hover effect from user name on a DM creation UI (#10887)
Browse files Browse the repository at this point in the history
  • Loading branch information
luixxiul committed May 30, 2023
1 parent 938aefc commit 50f7317
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 5 deletions.
9 changes: 9 additions & 0 deletions cypress/e2e/invite/invite-dialog.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,15 @@ describe("Invite dialog", function () {
// Assert that the invite dialog disappears
cy.get(".mx_InviteDialog_other").should("not.exist");

// Assert that the hovered user name on invitation UI does not have background color
// TODO: implement the test on room-header.spec.ts
cy.get(".mx_RoomHeader").within(() => {
cy.get(".mx_RoomHeader_name--textonly")
.realHover()
.get(".mx_RoomHeader_name--textonly:hover")
.should("have.css", "background-color", "rgba(0, 0, 0, 0)");
});

// Send a message to invite the bots
cy.getComposer().type("Hello{enter}");

Expand Down
15 changes: 10 additions & 5 deletions res/css/views/rooms/_RoomHeader.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ limitations under the License.
padding: 1px 4px;
display: flex;
user-select: none;
cursor: pointer;

&:hover {
background-color: $quinary-content;
Expand All @@ -102,6 +103,14 @@ limitations under the License.
background-color: $tertiary-content;
}

&.mx_RoomHeader_name--textonly {
cursor: unset;

&:hover {
background-color: unset;
}
}

&[aria-expanded="true"] {
background-color: $quinary-content;

Expand All @@ -120,11 +129,6 @@ limitations under the License.
opacity: 0.6;
}

.mx_RoomHeader_name:not(.mx_RoomHeader_name--textonly),
.mx_RoomHeader_avatar {
cursor: pointer;
}

.mx_RoomTopic {
position: relative;
cursor: pointer;
Expand Down Expand Up @@ -157,6 +161,7 @@ limitations under the License.
flex: 0;
margin: 0 7px;
position: relative;
cursor: pointer;
}

.mx_RoomHeader_avatar .mx_BaseAvatar_image {
Expand Down

0 comments on commit 50f7317

Please sign in to comment.