Release Sign in with QR out of labs #10066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
added
the
T-Enhancement
hughns
changed the title
hughns
force-pushed
the
hughns/graduate-qr-signin-from-labs
branch
from
98d85bb
to
9b12f9d
Compare
|
This PR is currently in draft whilst I check if there are any underlying changes needed based on MSC feedback. |
hughns
force-pushed
the
hughns/graduate-qr-signin-from-labs
branch
from
d710061
to
dd97109
Compare
This was referenced Feb 14, 2023
|
Having reviewed the dependencies for rollout it is actually safe to get this merged ahead of #10165. |
|
@hughns looks like this was merged ahead of sign off from QA which was requested? |
hughns
added a commit
that referenced
this pull request
Feb 16, 2023
|
My apologies for taking so long to get back to you on this. I tested this using element.io as the homeserver on iOS and Android, not encountering any obvious issues. I also checked using matrix.org as the homeserver to verify QR code sign-in didn't show up and confirmed this working as expected too.
I am waiting to be added to element-qa on github so I can mark this as approved. |
hughns
added a commit
that referenced
this pull request
Feb 17, 2023
3 tasks
|
@ashughes1 thank you very much. I've created #10182 to reapply this change. Apologies for the extra hassle I caused for everyone on the premature merge. |
su-ex
added a commit
to SchildiChat/element-desktop
that referenced
this pull request
Mar 15, 2023
* Remove experimental PWA support for Firefox and Safari ([\#24630](element-hq/element-web#24630)). * Fix block code styling in rich text editor ([\#10246](matrix-org/matrix-react-sdk#10246)). Contributed by @alunturner. * Poll history: fetch more poll history ([\#10235](matrix-org/matrix-react-sdk#10235)). Contributed by @kerryarchibald. * Sort short/exact emoji matches before longer incomplete matches ([\#10212](matrix-org/matrix-react-sdk#10212)). Fixes element-hq/element-web#23210. Contributed by @grimhilt. * Poll history: detail screen ([\#10172](matrix-org/matrix-react-sdk#10172)). Contributed by @kerryarchibald. * Provide a more detailed error message than "No known servers" ([\#6048](matrix-org/matrix-react-sdk#6048)). Fixes element-hq/element-web#13247. Contributed by @aaronraimist. * Say when a call was answered from a different device ([\#10224](matrix-org/matrix-react-sdk#10224)). * Widget permissions customizations using module api ([\#10121](matrix-org/matrix-react-sdk#10121)). Contributed by @maheichyk. * Fix copy button icon overlapping with copyable text ([\#10227](matrix-org/matrix-react-sdk#10227)). Contributed by @Adesh-Pandey. * Support joining non-peekable rooms via the module API ([\#10154](matrix-org/matrix-react-sdk#10154)). Contributed by @maheichyk. * The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\#10200](matrix-org/matrix-react-sdk#10200)). * Do not prompt for a password when doing a „reset all“ after login ([\#10208](matrix-org/matrix-react-sdk#10208)). * Display "The sender has blocked you from receiving this message" error message instead of "Unable to decrypt message" ([\#10202](matrix-org/matrix-react-sdk#10202)). Contributed by @florianduros. * Polls: show warning about undecryptable relations ([\#10179](matrix-org/matrix-react-sdk#10179)). Contributed by @kerryarchibald. * Poll history: fetch last 30 days of polls ([\#10157](matrix-org/matrix-react-sdk#10157)). Contributed by @kerryarchibald. * Poll history - ended polls list items ([\#10119](matrix-org/matrix-react-sdk#10119)). Contributed by @kerryarchibald. * Remove threads labs flag and the ability to disable threads ([\#9878](matrix-org/matrix-react-sdk#9878)). Fixes element-hq/element-web#24365. * Show a success dialog after setting up the key backup ([\#10177](matrix-org/matrix-react-sdk#10177)). Fixes element-hq/element-web#24487. * Release Sign in with QR out of labs ([\#10182](matrix-org/matrix-react-sdk#10182)). Contributed by @hughns. * Release Sign in with QR out of labs ([\#10066](matrix-org/matrix-react-sdk#10066)). Contributed by @hughns. * Hide indent button in rte ([\#10149](matrix-org/matrix-react-sdk#10149)). Contributed by @alunturner. * Add option to find own location in map views ([\#10083](matrix-org/matrix-react-sdk#10083)). * Render poll end events in timeline ([\#10027](matrix-org/matrix-react-sdk#10027)). Contributed by @kerryarchibald. * Let electron-builder correctly set StartupWMClass ([\element-hq#526](element-hq#526)). Fixes element-hq/element-web#13780. * Use the room avatar as a placeholder in calls ([\#10231](matrix-org/matrix-react-sdk#10231)). * Fix calls showing as 'connecting' after hangup ([\#10223](matrix-org/matrix-react-sdk#10223)). * Stop access token overflowing the box ([\#10069](matrix-org/matrix-react-sdk#10069)). Fixes element-hq/element-web#24023. Contributed by @sbjaj33. * Prevent multiple Jitsi calls started at the same time ([\#10183](matrix-org/matrix-react-sdk#10183)). Fixes element-hq/element-web#23009. * Make localization keys compatible with agglutinative and/or SOV type languages ([\#10159](matrix-org/matrix-react-sdk#10159)). Contributed by @luixxiul. * Add link to next file in the export ([\#10190](matrix-org/matrix-react-sdk#10190)). Fixes element-hq/element-web#20272. Contributed by @grimhilt. * Ended poll tiles: add ended the poll message ([\#10193](matrix-org/matrix-react-sdk#10193)). Fixes element-hq/element-web#24579. Contributed by @kerryarchibald. * Fix accidentally inverted condition for room ordering ([\#10178](matrix-org/matrix-react-sdk#10178)). Fixes element-hq/element-web#24527. Contributed by @justjanne. * Re-focus the composer on dialogue quit ([\#10007](matrix-org/matrix-react-sdk#10007)). Fixes element-hq/element-web#22832. Contributed by @Ashu999. * Try to resolve emails before creating a DM ([\#10164](matrix-org/matrix-react-sdk#10164)). * Disable poll response loading test ([\#10168](matrix-org/matrix-react-sdk#10168)). Contributed by @justjanne. * Fix email lookup in invite dialog ([\#10150](matrix-org/matrix-react-sdk#10150)). Fixes element-hq/element-web#23353. * Remove duplicate white space characters from translation keys ([\#10152](matrix-org/matrix-react-sdk#10152)). Contributed by @luixxiul. * Fix the caption of new sessions manager on Labs settings page for localization ([\#10143](matrix-org/matrix-react-sdk#10143)). Contributed by @luixxiul. * Prevent start another DM with a user if one already exists ([\#10127](matrix-org/matrix-react-sdk#10127)). Fixes element-hq/element-web#23138. * Remove white space characters before the horizontal ellipsis ([\#10130](matrix-org/matrix-react-sdk#10130)). Contributed by @luixxiul. * Fix Selectable Text on 'Delete All' and 'Retry All' Buttons ([\#10128](matrix-org/matrix-react-sdk#10128)). Fixes element-hq/element-web#23232. Contributed by @akshattchhabra. * Correctly Identify emoticons ([\#10108](matrix-org/matrix-react-sdk#10108)). Fixes element-hq/element-web#19472. Contributed by @adarsh-sgh. * Remove a redundant white space ([\#10129](matrix-org/matrix-react-sdk#10129)). Contributed by @luixxiul.
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this pull request
Mar 15, 2023
* Fix block code styling in rich text editor ([\matrix-org#10246](matrix-org#10246)). Contributed by @alunturner. * Poll history: fetch more poll history ([\matrix-org#10235](matrix-org#10235)). Contributed by @kerryarchibald. * Sort short/exact emoji matches before longer incomplete matches ([\matrix-org#10212](matrix-org#10212)). Fixes element-hq/element-web#23210. Contributed by @grimhilt. * Poll history: detail screen ([\matrix-org#10172](matrix-org#10172)). Contributed by @kerryarchibald. * Provide a more detailed error message than "No known servers" ([\matrix-org#6048](matrix-org#6048)). Fixes element-hq/element-web#13247. Contributed by @aaronraimist. * Say when a call was answered from a different device ([\matrix-org#10224](matrix-org#10224)). * Widget permissions customizations using module api ([\matrix-org#10121](matrix-org#10121)). Contributed by @maheichyk. * Fix copy button icon overlapping with copyable text ([\matrix-org#10227](matrix-org#10227)). Contributed by @Adesh-Pandey. * Support joining non-peekable rooms via the module API ([\matrix-org#10154](matrix-org#10154)). Contributed by @maheichyk. * The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\matrix-org#10200](matrix-org#10200)). * Do not prompt for a password when doing a „reset all“ after login ([\matrix-org#10208](matrix-org#10208)). * Display "The sender has blocked you from receiving this message" error message instead of "Unable to decrypt message" ([\matrix-org#10202](matrix-org#10202)). Contributed by @florianduros. * Polls: show warning about undecryptable relations ([\matrix-org#10179](matrix-org#10179)). Contributed by @kerryarchibald. * Poll history: fetch last 30 days of polls ([\matrix-org#10157](matrix-org#10157)). Contributed by @kerryarchibald. * Poll history - ended polls list items ([\matrix-org#10119](matrix-org#10119)). Contributed by @kerryarchibald. * Remove threads labs flag and the ability to disable threads ([\matrix-org#9878](matrix-org#9878)). Fixes element-hq/element-web#24365. * Show a success dialog after setting up the key backup ([\matrix-org#10177](matrix-org#10177)). Fixes element-hq/element-web#24487. * Release Sign in with QR out of labs ([\matrix-org#10066](matrix-org#10066)). Contributed by @hughns. * Hide indent button in rte ([\matrix-org#10149](matrix-org#10149)). Contributed by @alunturner. * Add option to find own location in map views ([\matrix-org#10083](matrix-org#10083)). * Render poll end events in timeline ([\matrix-org#10027](matrix-org#10027)). Contributed by @kerryarchibald. * Use the room avatar as a placeholder in calls ([\matrix-org#10231](matrix-org#10231)). * Fix calls showing as 'connecting' after hangup ([\matrix-org#10223](matrix-org#10223)). * Stop access token overflowing the box ([\matrix-org#10069](matrix-org#10069)). Fixes element-hq/element-web#24023. Contributed by @sbjaj33. * Prevent multiple Jitsi calls started at the same time ([\matrix-org#10183](matrix-org#10183)). Fixes element-hq/element-web#23009. * Make localization keys compatible with agglutinative and/or SOV type languages ([\matrix-org#10159](matrix-org#10159)). Contributed by @luixxiul. * Add link to next file in the export ([\matrix-org#10190](matrix-org#10190)). Fixes element-hq/element-web#20272. Contributed by @grimhilt. * Ended poll tiles: add ended the poll message ([\matrix-org#10193](matrix-org#10193)). Fixes element-hq/element-web#24579. Contributed by @kerryarchibald. * Fix accidentally inverted condition for room ordering ([\matrix-org#10178](matrix-org#10178)). Fixes element-hq/element-web#24527. Contributed by @justjanne. * Re-focus the composer on dialogue quit ([\matrix-org#10007](matrix-org#10007)). Fixes element-hq/element-web#22832. Contributed by @Ashu999. * Try to resolve emails before creating a DM ([\matrix-org#10164](matrix-org#10164)). * Disable poll response loading test ([\matrix-org#10168](matrix-org#10168)). Contributed by @justjanne. * Fix email lookup in invite dialog ([\matrix-org#10150](matrix-org#10150)). Fixes element-hq/element-web#23353. * Remove duplicate white space characters from translation keys ([\matrix-org#10152](matrix-org#10152)). Contributed by @luixxiul. * Fix the caption of new sessions manager on Labs settings page for localization ([\matrix-org#10143](matrix-org#10143)). Contributed by @luixxiul. * Prevent start another DM with a user if one already exists ([\matrix-org#10127](matrix-org#10127)). Fixes element-hq/element-web#23138. * Remove white space characters before the horizontal ellipsis ([\matrix-org#10130](matrix-org#10130)). Contributed by @luixxiul. * Fix Selectable Text on 'Delete All' and 'Retry All' Buttons ([\matrix-org#10128](matrix-org#10128)). Fixes element-hq/element-web#23232. Contributed by @akshattchhabra. * Correctly Identify emoticons ([\matrix-org#10108](matrix-org#10108)). Fixes element-hq/element-web#19472. Contributed by @adarsh-sgh. * Remove a redundant white space ([\matrix-org#10129](matrix-org#10129)). Contributed by @luixxiul.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "Sign in with QR" capability in Settings requires user opt-in to the Labs flag as well as server side support.
This PR proposes graduating it from Labs and enabling for all. It would only show where the homeserver supports it.
Checklist
element-web notes: Release Sign in with QR out of labs (#10066).
Here's what your changelog entry will look like:
✨ Features