-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poll history - remove active development labs flag #10357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
@kerryarchibald releasing features from labs needs explicit sign off from product, please acquire posthumously or it'll need reverting |
It should ideally have a review from QA as well ;) |
There is some context missing here. This is a former PS project and, as such, has been managed in Jira. Design review has been completed in https://element-io.atlassian.net/browse/PSG-1179 and cross-platform testing was covered in https://element-io.atlassian.net/browse/PSG-1054. @jakewb-b would you mind giving us formal product approval for the delabsing in retrospect? |
Thanks. De-labsing this is approved from the product POV. |
@jakewb-b can we have a checkmark please |
@t3chguy - as far as I can see, I don't have the ability to add a review anymore, presumably because this is already merged. Or am I missing something? |
oh indeed. ah well thanks for trying |
Polls history is feature complete and has been reviewed by design (internal ticket here)
This PR removes the labs flag used to hide poll history during active development.
Poll history is now accessible through the room info panel and the room settings:
![Screenshot 2023-03-14 at 10 40 33](https://user-images.githubusercontent.com/3055605/224838593-ae3d9a43-c677-4fcd-a7a9-1a1aa0cbc6c3.png)
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.