Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll history - remove active development labs flag #10357

Merged
merged 8 commits into from
Mar 15, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Mar 13, 2023

Polls history is feature complete and has been reviewed by design (internal ticket here)

This PR removes the labs flag used to hide poll history during active development.

Poll history is now accessible through the room info panel and the room settings:
Screenshot 2023-03-14 at 10 40 33

Screenshot 2023-03-14 at 14 08 00

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 13, 2023
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@kerryarchibald kerryarchibald enabled auto-merge (squash) March 15, 2023 20:32
@kerryarchibald kerryarchibald merged commit 2344eaa into develop Mar 15, 2023
@kerryarchibald kerryarchibald deleted the kerry/poll-history-unlabs branch March 15, 2023 20:54
@t3chguy
Copy link
Member

t3chguy commented Mar 15, 2023

@kerryarchibald releasing features from labs needs explicit sign off from product, please acquire posthumously or it'll need reverting

@kittykat
Copy link
Contributor

It should ideally have a review from QA as well ;)

@Johennes
Copy link
Contributor

Johennes commented Mar 16, 2023

There is some context missing here. This is a former PS project and, as such, has been managed in Jira. Design review has been completed in https://element-io.atlassian.net/browse/PSG-1179 and cross-platform testing was covered in https://element-io.atlassian.net/browse/PSG-1054.

@jakewb-b would you mind giving us formal product approval for the delabsing in retrospect?

@jakewb-b
Copy link

Thanks. De-labsing this is approved from the product POV.

@t3chguy
Copy link
Member

t3chguy commented Mar 16, 2023

@jakewb-b can we have a checkmark please

image

@Johennes Johennes requested review from jakewb-b and removed request for a team March 16, 2023 11:53
@jakewb-b
Copy link

@t3chguy - as far as I can see, I don't have the ability to add a review anymore, presumably because this is already merged. Or am I missing something?

@t3chguy
Copy link
Member

t3chguy commented Mar 16, 2023

oh indeed. ah well thanks for trying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants