Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply strictNullChecks to src/components/views/dialogs/devtools/* #10391

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Mar 15, 2023

Fixes element-hq/element-web#24836
For element-hq/element-web#21967

*** auto merge enabled ***

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 15, 2023
@kerryarchibald
Copy link
Contributor Author

Enabling auto merge since I'll be away next week

@kerryarchibald kerryarchibald merged commit b2c0466 into develop Mar 16, 2023
@kerryarchibald kerryarchibald deleted the kerry/24836/strictnull-devtools branch March 16, 2023 23:58
tulir added a commit to maunium/matrix-react-sdk that referenced this pull request Apr 23, 2023
Regressed in matrix-org#10391

Signed-off-by: Tulir Asokan <tulir@maunium.net>
tulir added a commit to maunium/matrix-react-sdk that referenced this pull request Apr 23, 2023
It regressed from `{\n\n}` to an empty string in matrix-org#10391

Signed-off-by: Tulir Asokan <tulir@maunium.net>
t3chguy pushed a commit that referenced this pull request Apr 24, 2023
It regressed from `{\n\n}` to an empty string in #10391

Signed-off-by: Tulir Asokan <tulir@maunium.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply strictNullChecks to src/components/views/dialogs/devtools/*
2 participants