Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing develop with mis-matched snapshots #10411

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fix failing develop with mis-matched snapshots #10411

merged 1 commit into from
Mar 20, 2023

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Mar 20, 2023 •
edited
Loading

Fix failing develop with mis-matched snapshots

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@MadLittleMods
Fix failing develop with mis-matched snapshots
3931ab9 
Date separator markup updated in #10404

While some new snapshot tests added in #10353
@MadLittleMods MadLittleMods requested a review from a team as a code owner March 20, 2023 16:25
@MadLittleMods MadLittleMods added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 20, 2023
@robintown robintown removed the request for review from kerryarchibald March 20, 2023 16:37
@MadLittleMods MadLittleMods merged commit 2245190 into develop Mar 20, 2023
@MadLittleMods MadLittleMods deleted the madlittlemods/fix-failing-develop-from-long-merges branch March 20, 2023 16:52
@MadLittleMods
Copy link
Contributor Author

Thanks for the quick review to get everything green @robintown 🐸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MadLittleMods @robintown