Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unique keys for voice broadcast pips #10457

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Use unique keys for voice broadcast pips #10457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf15b38
Use unique keys for voice broadcast pips
weeman1337 Mar 27, 2023
deff8a5
Merge branch 'develop' into weeman1337/vb-pip-keys
weeman1337 Mar 27, 2023
6c006ef
Merge branch 'develop' into weeman1337/vb-pip-keys
weeman1337 Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/structures/PipContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ class PipContainerInner extends React.Component<IProps, IState> {
);

return ({ onStartMoving }) => (
<div key={voiceBroadcastPlayback.infoEvent.getId()} onMouseDown={onStartMoving}>
<div key={`vb-playback-${voiceBroadcastPlayback.infoEvent.getId()}`} onMouseDown={onStartMoving}>
{content}
</div>
);
Expand All @@ -272,7 +272,7 @@ class PipContainerInner extends React.Component<IProps, IState> {
voiceBroadcastPreRecording: VoiceBroadcastPreRecording,
): CreatePipChildren {
return ({ onStartMoving }) => (
<div onMouseDown={onStartMoving}>
<div key="vb-pre-recording" onMouseDown={onStartMoving}>
<VoiceBroadcastPreRecordingPip voiceBroadcastPreRecording={voiceBroadcastPreRecording} />
</div>
);
Expand All @@ -282,7 +282,7 @@ class PipContainerInner extends React.Component<IProps, IState> {
voiceBroadcastRecording: VoiceBroadcastRecording,
): CreatePipChildren {
return ({ onStartMoving }) => (
<div onMouseDown={onStartMoving}>
<div key={`vb-recording-${voiceBroadcastRecording.infoEvent.getId()}`} onMouseDown={onStartMoving}>
<VoiceBroadcastRecordingPip recording={voiceBroadcastRecording} />
</div>
);
Expand Down