Update header buttons of RoomHeaderButtons
#10495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
luixxiul
changed the title
RoomHeaderButtons
3 tasks
3 tasks
This was referenced May 5, 2023
3 tasks
3 tasks
Conform the rules - %s/mx_RoomHeader_button_highlight/mx_RoomHeader_button--highlight/g - %s/mx_RoomHeader_button_unread/mx_RoomHeader_button--unread/g Move declarations - Move mx_RoomHeader_button_unreadIndicator and mx_RoomHeader_button_unreadIndicator - Move mx_RoomHeader_button--* - Move mx_RoomHeader_button--unread - Move mx_RoomHeader_button--highlight and &:hover
…utton--* - mx_RoomHeader_button--forget - mx_RoomHeader_button--apps - mx_RoomHeader_button--search - mx_RoomHeader_button--invite - mx_RoomHeader_button--call--voice - mx_RoomHeader_button--call--video - mx_RoomHeader_button--close - mx_RoomHeader_button--minimise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require #10628
This PR intends to update header buttons inside
RoomHeaderButtonsby factoring style rules on_RightPanel.pcssrelated to the buttons, applying the naming rule on the style guide (this is a follow-up to #10155; changing only a couple of selectors there could have made the style rules more complicated than they are)To a reviewer: I would like to suggest adding
X-Needs-Percylabel and have Percy run to capture header buttons layout, whileroom-header.spec.tsshould cover the change by this PR.type: task
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.