Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude message timestamps from aria live region #10584

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Exclude message timestamps from aria live region #10584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c50f4c
Exclude message timestamps from aria live region
t3chguy Apr 12, 2023
1e37cd3
Merge branch 'develop' into t3chguy/fix/5696
t3chguy Apr 12, 2023
0054c76
Update snapshot
t3chguy Apr 12, 2023
5ec75fa
Merge remote-tracking branch 'origin/t3chguy/fix/5696' into t3chguy/f…
t3chguy Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/views/messages/MessageTimestamp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ interface IProps {
export default class MessageTimestamp extends React.Component<IProps> {
public render(): React.ReactNode {
const date = new Date(this.props.ts);
let timestamp;
let timestamp: string;
if (this.props.showRelative) {
timestamp = formatRelativeTime(date, this.props.showTwelveHour);
} else if (this.props.showFullDate) {
Expand All @@ -46,6 +46,7 @@ export default class MessageTimestamp extends React.Component<IProps> {
className="mx_MessageTimestamp"
title={formatFullDate(date, this.props.showTwelveHour)}
aria-hidden={true}
aria-live="off"
>
{timestamp}
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/components/views/rooms/EventTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ export class UnwrappedEventTile extends React.Component<EventTileProps, IState>

const timestamp = showTimestamp && ts ? messageTimestamp : null;

let reactionsRow;
let reactionsRow: JSX.Element | undefined;
if (!isRedacted) {
reactionsRow = (
<ReactionsRow
Expand Down
2 changes: 1 addition & 1 deletion test/utils/exportUtils/__snapshots__/HTMLExport-test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.