Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly translate errors in ChangePassword.tsx so they show up translated to the user but not in our logs #10615

Merged
merged 12 commits into from
Apr 24, 2023
Merged

Properly translate errors in ChangePassword.tsx so they show up translated to the user but not in our logs #10615

merged 12 commits into from
Apr 24, 2023

Commits on Apr 15, 2023

  1. Properly translate errors in ChangePassword.tsx 

    So they show up translated to the user but not in our logs.

Part of element-hq/element-web#9597 and also fixes it
since it's the last piece mentioned (there could be other cases we log translated strings)

Fix element-hq/element-web#9597
    @MadLittleMods
    MadLittleMods committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    32ece81 View commit details
    Browse the repository at this point in the history

  2. Make more useful

    @MadLittleMods
    MadLittleMods committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    07a0a74 View commit details
    Browse the repository at this point in the history

  3. Update i18n strings

    @MadLittleMods
    MadLittleMods committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    c62c6c9 View commit details
    Browse the repository at this point in the history

  4. No need to checkPassword since field validation already covers this 

    See #10615 (comment)

Both of the error cases are covered by the logic in `verifyFieldsBeforeSubmit()` just above
and there is no way `checkPassword` would ever throw one of these errors since they are
already valid by the time it reaches here.
    @MadLittleMods
    MadLittleMods committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    7786dd1 View commit details
    Browse the repository at this point in the history

  5. Update i18n strings

    @MadLittleMods
    MadLittleMods committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    a7c2fe4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into madlittlemods/9597-properly-translate-cha… 

    …nge-password-flow
    @MadLittleMods
    MadLittleMods committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    772c15d View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Revert "No need to checkPassword since field validation already cover… 

    …s this"

This reverts commit 7786dd1.
    @MadLittleMods
    MadLittleMods committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    329b868 View commit details
    Browse the repository at this point in the history

  2. Update i18n strings

    @MadLittleMods
    MadLittleMods committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    93f238b View commit details
    Browse the repository at this point in the history

  3. Add todo context to note that we can remove this logic in the future

    @MadLittleMods
    MadLittleMods committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e0fbd73 View commit details
    Browse the repository at this point in the history

  4. Ensure is an error

    @MadLittleMods
    MadLittleMods committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1f8bd91 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into madlittlemods/9597-properly-translate-cha… 

    …nge-password-flow
    @MadLittleMods
    MadLittleMods committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    fc70a22 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Remove else 

    See #10615 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    798bb19 View commit details
    Browse the repository at this point in the history