-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uses of checkDeviceTrust
with getDeviceVerificationStatus
#10663
Merged
richvdh
merged 12 commits into
develop
from
rav/element-r/01_device_verification_status
Apr 24, 2023
Merged
Replace uses of checkDeviceTrust
with getDeviceVerificationStatus
#10663
richvdh
merged 12 commits into
develop
from
rav/element-r/01_device_verification_status
Apr 24, 2023
Commits on Apr 21, 2023
-
Use
fetchDevicesWithVerification
in DevicesPanelWe have a method called `fetchDevicesWithVerification` which is currently used in the new Session manager. Let's use it for the (old) Devices Panel too, because it allows us to check the device verification upfront, rather than on the fly, which is going to be handy when that operation becomes async
Configuration menu - View commit details
-
Copy full SHA for 4dffcf6 - Browse repository at this point
Copy the full SHA 4dffcf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f706559 - Browse repository at this point
Copy the full SHA f706559View commit details -
cases of
checkDeviceTrust
that needasyncSome
these are in an async method, but currently use `some`. We need to invent an `asyncSome` (we already have an `asyncEvery`) and use that
Configuration menu - View commit details
-
Copy full SHA for 6c6fe7f - Browse repository at this point
Copy the full SHA 6c6fe7fView commit details -
isDeviceVerified
: switch togetDeviceVerificationStatus
... which means making it async
Configuration menu - View commit details
-
Copy full SHA for 432e293 - Browse repository at this point
Copy the full SHA 432e293View commit details -
EventTile: use
getDeviceVerificationStatus
This is ok except we need an "unmounted" guard because it's an old-style componment
Configuration menu - View commit details
-
Copy full SHA for ef47246 - Browse repository at this point
Copy the full SHA ef47246View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d2d47b - Browse repository at this point
Copy the full SHA 9d2d47bView commit details -
Configuration menu - View commit details
-
Copy full SHA for edfad2b - Browse repository at this point
Copy the full SHA edfad2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74d5696 - Browse repository at this point
Copy the full SHA 74d5696View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c88d94 - Browse repository at this point
Copy the full SHA 3c88d94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cc6e40 - Browse repository at this point
Copy the full SHA 1cc6e40View commit details
Commits on Apr 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8b72ebf - Browse repository at this point
Copy the full SHA 8b72ebfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02f8263 - Browse repository at this point
Copy the full SHA 02f8263View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.