Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let TimelinePanel only send a receipt if there is an event #10912

Merged
merged 1 commit into from
May 16, 2023
Merged

Let TimelinePanel only send a receipt if there is an event #10912

merged 1 commit into from
May 16, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented May 16, 2023 •
edited by github-actions bot
Loading

fixes element-hq/element-web#25381
fixes element-hq/element-web#25374

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 changed the title Let TimelinePanel not send a receipt if there is no event Let TimelinePanel only send a receipt if there is an event May 16, 2023
@weeman1337 weeman1337 added T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Release-Blocker This affects the current release cycle and must be solved for a release to happen backport staging Label to automatically backport PR to staging branch labels May 16, 2023
@weeman1337 weeman1337 removed the backport staging Label to automatically backport PR to staging branch label May 16, 2023
@weeman1337 weeman1337 marked this pull request as ready for review May 16, 2023 11:21
@weeman1337 weeman1337 requested a review from a team as a code owner May 16, 2023 11:21
@luixxiul
Copy link
Contributor

Will this PR fix this issue too? element-hq/element-web#25374

@weeman1337
Copy link
Contributor Author

Will this PR fix this issue too? vector-im/element-web#25374

Yes. Thanks for mentioning it 👍

@t3chguy t3chguy enabled auto-merge May 16, 2023 11:34
@t3chguy t3chguy added this pull request to the merge queue May 16, 2023
Merged via the queue into develop with commit acdbae3 May 16, 2023
45 of 59 checks passed
@t3chguy t3chguy deleted the weeman1337/fix-timeline-panel-receipt branch May 16, 2023 12:04
@andybalaam andybalaam mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@richvdh richvdh Awaiting requested review from richvdh

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Milestone
No milestone
3 participants
@weeman1337 @luixxiul @t3chguy