Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cypress E2E test of general room settings tab with Percy snapshots #10997

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Add Cypress E2E test of general room settings tab with Percy snapshots #10997

merged 1 commit into from
Jun 5, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 26, 2023

Closes element-hq/element-web#25452

This PR suggests to add general-room-settings-tab.spec.ts for the room settings tab (General) with Percy snapshots to capture visual regressions like element-hq/element-web#25451 and element-hq/element-web#25455.

It is expected that the Percy will not take the snapshots as expected until #10947 is merged. Once it is merged, Percy should be able to take snapshots like below (with local addresses area collapsed and expanded):

0

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 26, 2023
@luixxiul luixxiul marked this pull request as ready for review May 26, 2023 15:26
@luixxiul luixxiul requested a review from a team as a code owner May 26, 2023 15:26
@kerryarchibald kerryarchibald added the X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue label May 29, 2023
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is really helpful.

@robintown robintown added this pull request to the merge queue Jun 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 2, 2023
@robintown robintown removed the X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue label Jun 2, 2023
@robintown robintown enabled auto-merge June 2, 2023 18:18
@robintown robintown added this pull request to the merge queue Jun 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 2, 2023
@t3chguy t3chguy added this pull request to the merge queue Jun 5, 2023
Merged via the queue into matrix-org:develop with commit 6b1c2e0 Jun 5, 2023
34 checks passed
@luixxiul luixxiul deleted the GeneralRoomSettingsTab branch June 5, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Percy snapshot test for GeneralRoomSettingsTab
4 participants