Fix Safari IME support #11016
Merged
Fix Safari IME support #11016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
|
I tried to manually do the test on Safari, Firefox and Chromium. I was able start direct chat and send the Hello, not sure what happened in cypress... |
|
Hello. Firstly thanks for the contribution and completely agree with the sentiment towards Safari. Super useful linked article too. Playing around with this code locally in safari, it works as you described it. However I'm not convinced we need to add the When I remove Would you mind trying this out and seeing if you agree with what I've said? |
|
Oh yeah. You're right 🤣 |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 3, 2024
Weirdly, there is no 1.11.56, so it apparently was skipped? Changes in [1.11.57](https://github.com/element-hq/element-web/releases/tag/v1.11.57) (2024-01-31) ================================================================================================== ## 🦖 Deprecations * Deprecate welcome bot `welcome_user_id` support ([#26885](element-hq/element-web#26885)). Contributed by @t3chguy. ## ✨ Features * Expose apps/widgets ([#12071](matrix-org/matrix-react-sdk#12071)). Contributed by @charlynguyen. * Enable the rust-crypto labs button ([#12114](matrix-org/matrix-react-sdk#12114)). Contributed by @richvdh. * Show a progress bar while migrating from legacy crypto ([#12104](matrix-org/matrix-react-sdk#12104)). Contributed by @richvdh. * Update Twemoji to Jdecked v15.0.3 ([#12147](matrix-org/matrix-react-sdk#12147)). Contributed by @t3chguy. * Change Quick Settings icon ([#12141](matrix-org/matrix-react-sdk#12141)). Contributed by @florianduros. * Use Compound tooltips more widely ([#12128](matrix-org/matrix-react-sdk#12128)). Contributed by @t3chguy. ## 🐛 Bug Fixes * Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer \& other data ([#12166](matrix-org/matrix-react-sdk#12166)). Contributed by @t3chguy. * Fix account management link for delegated auth OIDC setups ([#12144](matrix-org/matrix-react-sdk#12144)). Contributed by @t3chguy. * Fix Safari IME support ([#11016](matrix-org/matrix-react-sdk#11016)). Contributed by @SuperKenVery. * Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12127](matrix-org/matrix-react-sdk#12127)). * Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12126](matrix-org/matrix-react-sdk#12126)). Contributed by @t3chguy. * Fix 1F97A and 1F979 in Twemoji COLR font ([#12177](matrix-org/matrix-react-sdk#12177)). ## ✨ Features * Expose apps/widgets ([#12071](matrix-org/matrix-react-sdk#12071)). Contributed by @charlynguyen. * Enable the rust-crypto labs button ([#12114](matrix-org/matrix-react-sdk#12114)). Contributed by @richvdh. * Show a progress bar while migrating from legacy crypto ([#12104](matrix-org/matrix-react-sdk#12104)). Contributed by @richvdh. * Update Twemoji to Jdecked v15.0.3 ([#12147](matrix-org/matrix-react-sdk#12147)). Contributed by @t3chguy. * Change Quick Settings icon ([#12141](matrix-org/matrix-react-sdk#12141)). Contributed by @florianduros. * Use Compound tooltips more widely ([#12128](matrix-org/matrix-react-sdk#12128)). Contributed by @t3chguy. ## 🐛 Bug Fixes * Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer \& other data ([#12166](matrix-org/matrix-react-sdk#12166)). Contributed by @t3chguy. * Fix account management link for delegated auth OIDC setups ([#12144](matrix-org/matrix-react-sdk#12144)). Contributed by @t3chguy. * Fix Safari IME support ([#11016](matrix-org/matrix-react-sdk#11016)). Contributed by @SuperKenVery. * Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12127](matrix-org/matrix-react-sdk#12127)). * Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12126](matrix-org/matrix-react-sdk#12126)). Contributed by @t3chguy. * Fix 1F97A and 1F979 in Twemoji COLR font ([#12177](matrix-org/matrix-react-sdk#12177)). ## ✨ Features * Use jitsi-lobby in video channel (video rooms) ([#26879](element-hq/element-web#26879)). Contributed by @toger5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Currently in Safari, when using IME, use
Enterto input the typed characters as text (rather than, say, selected Chinese characters), the whole message will be sent.After the fix, using
Enterto input characters in IME doesn't cause the message to be sent.Before:
After:
Tested on Safari, Firefox and Chromium. The problem is fixed on Safari and didn't cause issues on Firefox or Chromium.
See also: https://www.stum.de/2016/06/24/handling-ime-events-in-javascript/
Fuck safari. This is my 2nd pr for it...
Signed-off-by: 许煜恒 xyhken@icloud.com
Type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes