OIDC: unit test ServerPickerDialog #11019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryarchibald
added
the
T-Task
kerryarchibald
commented
May 31, 2023
|
|
||
| fireEvent.click(screen.getByText("Continue")); | ||
|
|
||
| // serverpicker still validates the 'other homeserver' field on submit |
There was a problem hiding this comment.
Logged a bug for this element-hq/element-web#25488
added 2 commits
May 31, 2023 14:09
t3chguy
reviewed
May 31, 2023
| @@ -202,6 +202,7 @@ export default class ServerPickerDialog extends React.PureComponent<IProps, ISta | |||
| value="true" | |||
| checked={this.state.defaultChosen} | |||
| onChange={this.onDefaultChosen} | |||
| aria-label={_t("Default homeserver")} | |||
There was a problem hiding this comment.
I'm not sure this is right, this is likely to clobber the reading of any child text like defaultServerName, why is this change in a PR titled unit testing?
There was a problem hiding this comment.
Good point. I wanted an easy way to select this for testing and the aria-label seemed harmless. Changed it to a testid.
added 2 commits
May 31, 2023 22:29
t3chguy
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test before making changes
For element-hq/element-web#25472
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.