Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow managing room knocks #11404

Merged
merged 3 commits into from Aug 16, 2023
Merged

Allow managing room knocks #11404

merged 3 commits into from Aug 16, 2023

Conversation

charlynguyen
Copy link
Contributor

@charlynguyen charlynguyen commented Aug 13, 2023 •
edited by github-actions bot

We @nordeck are currently implementing the knock rooms behind the feature flag feature_ask_to_join (introduced in #11182).

This pull request allows managing room knocks.

  • Introduce "People" tab in room settings dialog for knock rooms where all requests to join can be managed
  • Approve requests to join
  • Deny requests to join
  • Approve and deny require sufficient power levels or the action buttons will be disabled in the UI
  • Join request reasons are expandable/collapsable

Epic: element-hq/element-web#18655

Relates to

Screens / Videos

Room Settings Tab With Requests to Join

01-people-room-settings-tab

Join Request Reasons Are Expandable/Collapsable

02-people-room-settings-tab-see-less

Disabled Approve/Deny Buttons

03-people-room-settings-tab-actions-disabled

Demo

demo.mp4

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

Allow managing room knocks
fe8e29e 
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
@charlynguyen charlynguyen requested a review from a team as a code owner August 13, 2023 21:21
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Aug 13, 2023
@charlynguyen
Copy link
Contributor Author

FYI @daniellekirkwood 🙂

t3chguy
t3chguy reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally sane

src/components/views/settings/tabs/room/PeopleRoomSettingsTab.tsx Outdated Show resolved Hide resolved
src/components/views/dialogs/RoomSettingsDialog.tsx Show resolved Hide resolved
@richvdh richvdh removed their request for review August 14, 2023 11:52
Apply PR feedback
6dbb254 
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
Apply Sonar feedback
c77ba6d 
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
t3chguy
t3chguy approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, thanks!

@t3chguy t3chguy added this pull request to the merge queue Aug 16, 2023
Merged via the queue into matrix-org:develop with commit d569ba0 Aug 16, 2023
72 checks passed
@charlynguyen charlynguyen deleted the charlynguyen/allow-managing-room-knocks branch August 16, 2023 08:46
@catfromplan9
Copy link

Not seeing the people tab on my instance with this labs feature on

@t3chguy
Copy link
Member

t3chguy commented Aug 17, 2023

Not seeing the people tab on my instance with this labs feature on

Stop spamming your query over multiple issues.
element-hq/element-web#25923 (comment)

@andybalaam andybalaam mentioned this pull request Aug 22, 2023
Merged
@charlynguyen charlynguyen mentioned this pull request Aug 23, 2023
Closed
3 tasks
@daniellekirkwood
Copy link

@charlynguyen catching up on this PR now -- are there no people in the room in the demo video you shared? The designs show the whole people list in the new people tab but they're not showing in your screens :)

@charlynguyen charlynguyen mentioned this pull request Aug 29, 2023
Merged
3 tasks
This was referenced Aug 29, 2023
Closed
Merged
This was referenced Aug 29, 2023
Merged
Merged
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Aug 31, 2023
@Midar
Update chat/element-web to 1.11.40
f7ccbff 
Changes in [1.11.40](https://github.com/vector-im/element-web/releases/tag/v1.11.40) (2023-08-29)
=================================================================================================

## ✨ Features
 * Hide account deactivation for externally managed accounts ([\#11445](matrix-org/matrix-react-sdk#11445)). Fixes #26022. Contributed by @kerryarchibald.
 * OIDC: Redirect to delegated auth provider when signing out ([\#11432](matrix-org/matrix-react-sdk#11432)). Fixes #26000. Contributed by @kerryarchibald.
 * Disable 3pid fields in settings when `m.3pid_changes` capability is disabled ([\#11430](matrix-org/matrix-react-sdk#11430)). Fixes #25995. Contributed by @kerryarchibald.
 * OIDC: disable multi session signout for OIDC-aware servers in session manager ([\#11431](matrix-org/matrix-react-sdk#11431)). Contributed by @kerryarchibald.
 * Implement updated open dialog method of the Module API ([\#11395](matrix-org/matrix-react-sdk#11395)). Contributed by @dhenneke.
 * Polish & delabs `Exploring public spaces` feature ([\#11423](matrix-org/matrix-react-sdk#11423)).
 * Treat lists with a single empty item as plain text, not Markdown. ([\#6833](matrix-org/matrix-react-sdk#6833)). Fixes element-hq/element-meta#1265.
 * Allow managing room knocks ([\#11404](matrix-org/matrix-react-sdk#11404)). Contributed by @charlynguyen.
 * Pin the action buttons to the bottom of the scrollable dialogs ([\#11407](matrix-org/matrix-react-sdk#11407)). Contributed by @dhenneke.
 * Support Matrix 1.1 (drop legacy r0 versions) ([\#9819](matrix-org/matrix-react-sdk#9819)).

## 🐛 Bug Fixes
 * Fix path separator for Windows based systems ([\#25997](element-hq/element-web#25997)).
 * Fix instances of double translation and guard translation calls using typescript ([\#11443](matrix-org/matrix-react-sdk#11443)).
 * Fix export type "Current timeline" to match its behaviour to its name ([\#11426](matrix-org/matrix-react-sdk#11426)). Fixes #25988.
 * Fix Room Settings > Notifications file upload input being shown superfluously ([\#11415](matrix-org/matrix-react-sdk#11415)). Fixes #18392.
 * Simplify registration with email validation ([\#11398](matrix-org/matrix-react-sdk#11398)). Fixes #25832 #23601 and #22297.
 * correct home server URL ([\#11391](matrix-org/matrix-react-sdk#11391)). Fixes #25931. Contributed by @NSV1991.
 * Include non-matching DMs in Spotlight recent conversations when the DM's userId is part of the search API results ([\#11374](matrix-org/matrix-react-sdk#11374)). Contributed by @mgcm.
 * Fix useRoomMembers missing updates causing incorrect membership counts ([\#11392](matrix-org/matrix-react-sdk#11392)). Fixes #17096.
 * Show error when searching public rooms fails ([\#11378](matrix-org/matrix-react-sdk#11378)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@charlynguyen @catfromplan9 @t3chguy @daniellekirkwood