Fix read receipt tests with incorrect read counts #11465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These counts were transiently correct if the client was slow enough, so the tests usually passed, but actually they were wrong.
andybalaam
added
the
T-Task
t3chguy
approved these changes
Aug 24, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Fell out of merge queue because a single Cypress test file appears to have hung :-( |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
An unrelated Cypress test failed in the merge queue. Logging a flaky test issue and re-merging. |
|
Flaky test issue: element-hq/element-web#26053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These counts were transiently correct if the client was slow enough, so the tests usually passed, but actually they were wrong.
Part of element-hq/element-web#25449
This change is marked as an internal change (Task), so will not be included in the changelog.