Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: extract token persistence functions to utils #11690

Merged
merged 4 commits into from
Oct 2, 2023
Merged

OIDC: extract token persistence functions to utils #11690

merged 4 commits into from
Oct 2, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Oct 2, 2023 •
edited by github-actions bot

For element-hq/element-web#25839

Extract token persistence functions from Lifecycle to utils/tokens, so they can be used in OIDC utils without causing circular dependencies.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 2, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 2, 2023
View reviewed changes
src/utils/tokens/tokens.ts Dismissed Show dismissed Hide dismissed
src/utils/tokens/tokens.ts Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 2, 2023
View reviewed changes
src/utils/tokens/tokens.ts Dismissed Show dismissed Hide dismissed
@kerryarchibald kerryarchibald marked this pull request as ready for review October 2, 2023 04:05
@kerryarchibald kerryarchibald requested a review from a team as a code owner October 2, 2023 04:05
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 2, 2023
Merged via the queue into develop with commit 6685403 Oct 2, 2023
22 checks passed
@kerryarchibald kerryarchibald deleted the kerry/25392/extract-token-functions branch October 2, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kerryarchibald @t3chguy