Take RTE out of labs! 馃帀 #1176
Merged
Take RTE out of labs! 馃帀 #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops react-sdk from tracking any state previously stored for the purposes of enabling or disabling the lab feature that enabled the new MessageComposer. It is now enabled permanently. This is being done with the hope that we can get more feedback for it so that when we release we can be confident that people will be OK with the changes it brings.
dbkr
reviewed
Jul 4, 2017
| @@ -390,18 +388,6 @@ export default class MessageComposer extends React.Component { | |||
| ); | |||
| } | |||
|
|
|||
| let autoComplete; | |||
There was a problem hiding this comment.
Doesn't this want to be taken out of the if block rather than removed altogether?
There was a problem hiding this comment.
I thought the same but it's not referred to anywhere...
src/UserSettingsStore.js
Outdated
| this.LABS_FEATURES[1].name = _t("Matrix Apps"); | ||
| this.LABS_FEATURES.forEach((f) => { | ||
| f.name = _t(f._tName); | ||
| }); |
There was a problem hiding this comment.
Lumping this in with this change means it'll get reverted along with the rest of this PR if we end up finding showstopper bugs in RTE. Also it won't be picked up by my translations finder script which will only know about _t(<string literal>)
For scripts to easily find translations
lukebarnard1
pushed a commit
to element-hq/element-web
that referenced
this pull request
Jul 4, 2017
dbkr
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops react-sdk from tracking any state previously stored for the purposes of enabling or disabling the lab feature that enabled the new MessageComposer. It is now enabled permanently.
This is being done with the hope that we can get more feedback for it so that when we release we can be confident that people will be OK with the changes it brings.