Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests fixed by https://github.com/matrix-org/matrix-js-sdk/pull/3800 #11764

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Oct 17, 2023


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 17, 2023
Base automatically changed from andybalaam/enable-tests-fixed-by-stuck-notif-fix to develop October 18, 2023 16:49
@andybalaam andybalaam force-pushed the andybalaam/enable-test-fixed-by-3800 branch from c8e4a51 to ee28d4e Compare October 19, 2023 13:31
@andybalaam andybalaam marked this pull request as ready for review October 19, 2023 14:37
@andybalaam andybalaam requested a review from a team as a code owner October 19, 2023 14:37
@andybalaam andybalaam added this pull request to the merge queue Oct 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 19, 2023
@germain-gg germain-gg removed their request for review October 20, 2023 06:34
@andybalaam
Copy link
Contributor Author

Backing off this for now as this test is flaking the same way lots of others are, and I'm investigating those flakes.

@andybalaam andybalaam changed the title Enable test fixed by https://github.com/matrix-org/matrix-js-sdk/pull/3800 Enable tests fixed by https://github.com/matrix-org/matrix-js-sdk/pull/3800 Oct 20, 2023
@andybalaam andybalaam marked this pull request as draft October 20, 2023 15:46
@andybalaam
Copy link
Contributor Author

This needs to wait for matrix-org/matrix-js-sdk#3869

@andybalaam andybalaam force-pushed the andybalaam/enable-test-fixed-by-3800 branch from ee28d4e to 25d66e8 Compare November 15, 2023 08:26
@andybalaam andybalaam marked this pull request as ready for review November 15, 2023 08:26
@andybalaam andybalaam added this pull request to the merge queue Nov 15, 2023
Merged via the queue into develop with commit 9564009 Nov 15, 2023
85 checks passed
@andybalaam andybalaam deleted the andybalaam/enable-test-fixed-by-3800 branch November 15, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants