Add menu for legacy and element call in 1:1 rooms

[toger5]

This allows to also initiate element call calls in 1:1 rooms.

Signed-off-by: Timo K toger5@hotmail.de

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

---

Here's what your changelog entry will look like:

✨ Features

• Add menu for legacy and element call in 1:1 rooms (#11910). Contributed by @toger5.

[t3chguy]

This legacy room header is about to be thrown out, are you sure you wish to contribute to it?

[toger5]

Good question. I should also port it to the new one.
(will the right panel chat button be added to the new header before dropping the old one? Otherwise video rooms would be broken)

[t3chguy]

@kerryarchibald are you able to answer @toger5 - for I have no idea

[toger5]

Uh the new room header also drops jitsi support right? (choosing between jisti or ec. It just makes the choice based on flags) So it also drops the option to choose after clicking on a call in general...

I think in this case I want this to get merged. At least for testing/playing with it and if it gets dropped we need to decide what we do with the new header. Maybe we make it a feature flag then. But that needs some discussion in the Voip team I guess.

[kerryarchibald]

@toger5 element-hq/element-web#26181 will be fixed before the legacy room header is removed.

Uh the new room header also drops jitsi support right? (choosing between jisti or ec. It just makes the choice based on flags)

Right, the new room header chooses according to flags and element_call config.

I'm not sure this should be merged; if this is a feature we want it should be discussed with product and added to the new room header.

[toger5]

Since this exclusivly touches legacy files and is a fairly lightweight change I dont see why we would not merging it.
I am fine with it getting removed in the next weeks in favor of the new header. It provides a working solution until design has decided if we want EC 1:1 calls to be a feature flag or if it can be selected on the fly via a menu and we can implement the final decision in the new header.

[t3chguy]

@toger5 because the legacy header is still used in most production deployments today - we can't just add a feature only for it to be ripped out two weeks later after users start relying upon it

[toger5]

What if we add a feature flags: "use element call in 1:1 calls" and make the menu conditional?

[t3chguy]

I agree with Kerry that this feels like it needs product buy in as its something we're committing to supporting as a user facing feature or worse teasing people with then ripping out.

[toger5]

I just was about to add this behind a feature flag. It turns out it already is:
Its all behing a big if bracket: else if (groupCallsEnabled) { ... /*changes from this pr are here*/ }

So for users not having the feature flag enabled this would change nothing.