Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rejoin of knock rooms #11980

Merged
merged 3 commits into from Dec 4, 2023
Merged

Fix rejoin of knock rooms #11980

merged 3 commits into from Dec 4, 2023

Conversation

maheichyk
Copy link
Contributor

@maheichyk maheichyk commented Nov 30, 2023 •
edited by github-actions bot

This PR fixes the behavior that user cannot rejoin knock room after being kicked or banned/unbanned

Fixes: element-hq/element-web#26614

Epic: vector-im/element-web/issues/18655

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Type: defect

Here's what your changelog entry will look like:

馃悰 Bug Fixes

Fix rejoin of knock rooms
325c696 
Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Nov 30, 2023
@github-actions github-actions bot added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Nov 30, 2023
@maheichyk maheichyk marked this pull request as ready for review November 30, 2023 11:30
@maheichyk maheichyk requested a review from a team as a code owner November 30, 2023 11:30
@maheichyk
Copy link
Contributor Author

@richvdh, @t3chguy could you please review?

t3chguy
t3chguy approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, thanks

@t3chguy t3chguy added this pull request to the merge queue Dec 4, 2023
Merged via the queue into matrix-org:develop with commit 74ea0d1 Dec 4, 2023
21 checks passed
@maheichyk maheichyk deleted the nic/feat/knock-room-rejoin branch December 4, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Once a knock room member has been unbanned, they are stucked in the re-join room view
2 participants
@maheichyk @t3chguy