Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSC2965 OIDC Discovery implementation #12245

Merged
merged 39 commits into from Feb 23, 2024
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 13, 2024

Requires matrix-org/matrix-js-sdk#4064
Requires element-hq/element-web#27047
Fixes element-hq/element-web#26908


Here's what your changelog entry will look like:

✨ Features

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 13, 2024
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…if well-known is slow

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
… t3chguy/fix/26908

# Conflicts:
#	playwright/plugins/homeserver/synapse/index.ts
#	playwright/plugins/postgres/index.ts
#	playwright/plugins/sliding-sync-proxy/index.ts
#	src/Login.ts
#	src/stores/oidc/OidcClientStore.ts
#	src/utils/oidc/registerClient.ts
#	test/utils/oidc/registerClient-test.ts
… OIDC mode

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems plausible

src/stores/oidc/OidcClientStore.ts Outdated Show resolved Hide resolved
src/stores/oidc/OidcClientStore.ts Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@t3chguy t3chguy merged commit 7b1e8e3 into develop Feb 23, 2024
22 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/26908 branch February 23, 2024 16:43
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 13, 2024
https://build.opensuse.org/request/show/1157523
by user dheidler + anag+factory
- Version 1.11.60
  ## ✨ Features
  * Refine styles of controls to match Compound (matrix-org/matrix-react-sdk#12299). Contributed by @robintown.
  * Hide the archived section (matrix-org/matrix-react-sdk#12286). Contributed by @dbkr.
  * Add theme data to EC widget Url (matrix-org/matrix-react-sdk#12279). Contributed by @toger5.
  * Update MSC2965 OIDC Discovery implementation (matrix-org/matrix-react-sdk#12245). Contributed by @t3chguy.
  * Use green dot for activity notification in `LegacyRoomHeader` (matrix-org/matrix-react-sdk#12270). Contributed by @florianduros.
  ## 🐛 Bug Fixes
  * Fix requests for senders to submit auto-rageshakes (https://github.com/matrix-org/ma
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 13, 2024
https://build.opensuse.org/request/show/1157524
by user dheidler + anag+factory
- Version 1.11.60
  ## ✨ Features
  * Refine styles of controls to match Compound (matrix-org/matrix-react-sdk#12299). Contributed by @robintown.
  * Hide the archived section (matrix-org/matrix-react-sdk#12286). Contributed by @dbkr.
  * Add theme data to EC widget Url (matrix-org/matrix-react-sdk#12279). Contributed by @toger5.
  * Update MSC2965 OIDC Discovery implementation (matrix-org/matrix-react-sdk#12245). Contributed by @t3chguy.
  * Use green dot for activity notification in `LegacyRoomHeader` (matrix-org/matrix-react-sdk#12270). Contributed by @florianduros.
  ## 🐛 Bug Fixes
  * Fix requests for senders to submit auto-rageshakes (https://github.com/matrix-org/ma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MSC2965 support: discover the OIDC provider via C-S API instead of the well-known discovery
2 participants