Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable previously skipped Playwright crypto test for 'gray shields' #12249

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Feb 14, 2024

Fixes element-hq/element-web#26811

The test was incorrectly testing for the presence of a red shield. It was probably expecting a Message sent from a deleted device.
In that case it is true that the sending device is deleted, but the key is coming from the backup. At the moment keys coming from backup can't be linked back to the device that created them (until authenticated backup is implemented).
That's why the shield would be gray. If we can't establish authenticity, we can't make any checks on the device (is signed by it's owner? verified by us? is it deleted?)

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@BillCarsonFr BillCarsonFr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 14, 2024
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner February 14, 2024 09:53
@BillCarsonFr BillCarsonFr added this pull request to the merge queue Feb 15, 2024
Merged via the queue into develop with commit 342d0db Feb 15, 2024
27 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/restore_skipped_crypto_test branch February 15, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled Playwright test "Should show a grey padlock for a key restored from backup"
2 participants