Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow screenshot update docker to run multiple test files #12291

Merged
merged 1 commit into from Feb 28, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 27, 2024

The entrypoint script only passed the first argument so if you specified multiple test files it would only run the first.

This will need the docker image to be rebuilt on each machine you run it on to take effect.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

The entrypoint script only passed the first argument so if you specified
multiple test files it would only run the first.

This will need the docker image to be rebuilt on each machine you run it
on to take effect.
@dbkr dbkr added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Feb 27, 2024
@dbkr dbkr marked this pull request as ready for review February 27, 2024 16:39
@dbkr dbkr requested a review from a team as a code owner February 27, 2024 16:39
@dbkr dbkr added this pull request to the merge queue Feb 28, 2024
Merged via the queue into develop with commit 2402cd5 Feb 28, 2024
27 checks passed
@dbkr dbkr deleted the dbkr/screenshot_update_multiple_tests branch February 28, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants