Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve types for sendStateEvent #12331

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Improve types for sendStateEvent #12331

merged 7 commits into from
Mar 20, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 11, 2024 •
edited

@t3chguy
Improve types for sendStateEvent
4b3b64f 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 11, 2024
@t3chguy t3chguy requested a review from a team as a code owner March 11, 2024 11:54
@t3chguy t3chguy self-assigned this Mar 11, 2024
@t3chguy
Iterate
6124d58 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
richvdh
richvdh requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much stuff going on at once here. Separate moving stuff between files from changing stuff, please.

.eslintrc.js Outdated Show resolved Hide resolved
@t3chguy t3chguy mentioned this pull request Mar 18, 2024
Merged
@t3chguy
Move lint rule
cd558b5 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
a6355cb 
… t3chguy/better-types

# Conflicts:
#	src/@types/matrix-js-sdk.d.ts
#	src/models/Call.ts
@t3chguy t3chguy requested a review from richvdh March 19, 2024 11:16
richvdh
richvdh approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be just types and stuff.

@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
3de95a7 
… t3chguy/better-types

# Conflicts:
#	src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx
@t3chguy
Merge remote-tracking branch 'origin/t3chguy/better-types' into t3chg…
61d469f 
…uy/better-types
@t3chguy t3chguy merged commit 2cbf928 into develop Mar 20, 2024
21 of 22 checks passed
@t3chguy t3chguy deleted the t3chguy/better-types branch March 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t3chguy @richvdh