Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate styles around Link new device via QR #12356

Merged
merged 7 commits into from Mar 22, 2024
Merged

Iterate styles around Link new device via QR #12356

merged 7 commits into from Mar 22, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 21, 2024 •
edited

@t3chguy
Rearrange user settings tab order to move Sessions up to 2nd
ea2c6bf 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Iterate copy & iconography on Settings > Sessions > Link new device
bbe3008 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Iterate design of Scan QR code screen
d387034 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 21, 2024
@t3chguy t3chguy self-assigned this Mar 21, 2024
@t3chguy
Tweak styles
14684cc 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Update tests and snapshots
b361083 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Update tests and snapshots
83ab488 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Update screenshots
296de76 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy marked this pull request as ready for review March 21, 2024 15:25
@t3chguy t3chguy requested a review from a team as a code owner March 21, 2024 15:25
richvdh
richvdh approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible

@t3chguy t3chguy added this pull request to the merge queue Mar 22, 2024
Merged via the queue into develop with commit 56d7911 Mar 22, 2024
22 checks passed
@t3chguy t3chguy deleted the t3chguy/oidc-qr-prepare branch March 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t3chguy @richvdh