Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAC: Release Announcement #12380

Merged
merged 27 commits into from Apr 8, 2024
Merged

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Mar 27, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Needs element-hq/compound-web#154
Closes https://github.com/element-hq/wat-internal/issues/160

This PR introduce a new exciting feature to EW, the release announcement (RA).

The release announcement is displayed alongside a feature to inform the user of an important change in EW. It's built upon Release Announcement component of compound
Capture d’écran 2024-04-04 à 10 46 52

The RA is going through multiple features, one by one. (Currently there is only one feature, the Threads Activity Centre, which is using it). Only one RA can be displayed at one time and when a RA is viewed (the user clicks on the Ok button), it should not be displayed again on all the devices.

The goal of the ReleaseAnnouncementStore is to be sure that one RA is displayed and to store the RA viewed in the store settings in the account level.
Also the ReleaseAnnouncement component of EW is gluing the ReleaseAnnouncementStore and the RA component of compound.

The feature is enabled by default but can be disabled. It's disabled for the e2e for example and enabled for one e2e dedicated test suite to avoid to go trough the release announcement process on every test.

@florianduros florianduros added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 27, 2024
src/stores/ReleaseAnnouncementStore.ts Outdated Show resolved Hide resolved
src/stores/ReleaseAnnouncementStore.ts Outdated Show resolved Hide resolved
src/stores/ReleaseAnnouncementStore.ts Outdated Show resolved Hide resolved
test/components/structures/ReleaseAnnouncement-test.tsx Outdated Show resolved Hide resolved
test/stores/ReleaseAnnouncementStore-test.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Show resolved Hide resolved
src/hooks/useReleaseAnnouncement.ts Outdated Show resolved Hide resolved
@florianduros florianduros added this pull request to the merge queue Apr 8, 2024
Merged via the queue into develop with commit 5815e70 Apr 8, 2024
22 checks passed
@florianduros florianduros deleted the florianduros/tac/release-announcement branch April 8, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants