New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add activity toggle for TAC #12413
Add activity toggle for TAC #12413
Conversation
src/components/views/spaces/threads-activity-centre/useUnreadThreadRooms.ts
Outdated
Show resolved
Hide resolved
src/components/views/spaces/threads-activity-centre/useUnreadThreadRooms.ts
Outdated
Show resolved
Hide resolved
src/settings/Settings.tsx
Outdated
default: false, | ||
invertedSettingName: "feature_hidebold", | ||
}, | ||
"Notifications.hidebold_tac": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name hidebold_tac
is hard to understand. What bold means in TAC? Bold is the visual representation of a thread state. In our case we want to show only notifications and highlights if this settings is at true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was going for consistency with the other setting, but maybe it's better to just be clear. Renamed.
Takes the general activity/bold toggle out of labs and adds a setting to display activity in the TAC, as we did previously.
Checklist
public
/exported
symbols have accurate TSDoc documentation.