Switch to Rust crypto stack for all logins #12630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
T-Feature
T-Enhancement
Ignore the `feature_rust_crypto` and `RustCrypto.staged_rollout_percent` settings, and just use RustCrypto everywhere.
richvdh
force-pushed
the
rav/rust_migration_rollout_phase3
branch
from
f308397
to
b88fed2
Compare
richvdh
force-pushed
the
rav/rust_migration_rollout_phase3
branch
from
b88fed2
to
c60c6e5
Compare
We're not going to use the legacy stack any more.
richvdh
force-pushed
the
rav/rust_migration_rollout_phase3
branch
from
40e39bd
to
b840f35
Compare
richvdh
added
the
X-Release-Blocker
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Jun 21, 2024
As of matrix-org/matrix-react-sdk#12630, Rust crypto is no longer subject to config settings; they are no longer supported in config.
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Jun 26, 2024
Now that we use the Rust crypto stack (matrix-org/matrix-react-sdk#12630), the legacy olm library is unneeded. Remove all the dedicated cruft for loading it. (All this crap is why matrix-sdk-crypto-wasm has to base64 its wasm artifact, cf matrix-org/matrix-rust-sdk#1167.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch everybody over to the rust crypto stack. Existing logins will be migrated on app reload; new logins will receive Rust Crypto from the start.
Review commit-by-commit.
Follow-up PRs will remove the "Legacy Crypto" playwright test run, and update the settings documentation on Element Web.
Fixes: element-hq/element-web#27560
Fixes: element-hq/element-web#27001
Fixes: element-hq/element-web#21972
Fixes: element-hq/element-web#15476
Fixes: element-hq/element-web#24612
Fixes: element-hq/element-web#24682
Fixes: element-hq/element-web#25565