Implement sticky date separators #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `react-sticky` to implement sticky date separators. This will pin a date separator to the top of the timeline panel when the separator scrolls out of the top of the view. A known issue of this is that the spinner, which is in line with event tiles in the timeline, will appear to push the stuck date separator down. In reality the first date separator after the spinner is in line with event tiles and is not stuck because the spinner forces the timeline to be scrolled slightly further down than it would be otherwise. But also, date separators in the timeline (not "stuck") have a greater height. Ideally the date separator would be suppressed whilst back paginating, but this will cause the stuck separator to flicker on and off. This is why the suppression has been removed.
lukebarnard1
pushed a commit
to element-hq/element-web
that referenced
this pull request
Aug 30, 2017
dbkr
reviewed
Aug 31, 2017
| }); | ||
| } | ||
| }, | ||
|
|
There was a problem hiding this comment.
Hmm, you've done this now but we really should be using the i18n for date formatting: https://github.com/martinandert/counterpart#localization
There was a problem hiding this comment.
oh cool, I'll do that instead
| var sn = this._getScrollNode(); | ||
| debuglog("Scroll event: offset now:", sn.scrollTop, | ||
| "_lastSetScroll:", this._lastSetScroll); | ||
|
|
||
| this.node = sn; |
There was a problem hiding this comment.
Actually no, this is why any of the sticky stuff works and I 100% should have commented as such.
Should I split it up into several commits? I realise that it's all been done in one blob but need not go down in history as such. |
dbkr
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
react-stickyto implement sticky date separators. This will pin a date separator to the top of the timeline panel when the separator scrolls out of the top of the view.A known issue of this is that the spinner, which is in line with event tiles in the timeline, will appear to push the stuck date separator down. In reality the first date separator after the spinner is in line with event tiles and is not stuck because the spinner forces the timeline to be scrolled slightly further down than it would be otherwise. But also, date separators in the timeline (not "stuck") have a greater height.
Ideally the date separator would be suppressed whilst back paginating, but this will cause the stuck separator to flicker on and off. This is why the suppression has been removed.
Also,
DateUtils.formatDateSeparatorwas factored out ofDateSeparatorand fixed so that it will now display:codep element-hq/element-web#4939