Display whether the group summary/room list is loading #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a `ready` flag assigned to each fetching API used by the GroupServer. I've avoided making this generic for now for want of not doing so early.
dbkr
reviewed
Oct 31, 2017
| @@ -670,7 +677,7 @@ export default React.createClass({ | |||
| <h3>{ _t('Rooms') }</h3> | |||
| { addRoomRow } | |||
| </div> | |||
| <RoomDetailList rooms={this._groupStore.getGroupRooms()} /> | |||
| <RoomDetailList rooms={this.state.groupRooms} loading={this.state.groupRoomsLoading} /> | |||
There was a problem hiding this comment.
Is there a reason for passing this into RoomDetailList and letting it deal with the loading state rather than just showing a spinner in lieu of it?
There was a problem hiding this comment.
Not really, TBH. Happy do to the simpler thing of replacing it entirely with a spinner.
| @@ -96,6 +105,10 @@ export default class GroupStore extends EventEmitter { | |||
| this.removeListener('update', fn); | |||
| } | |||
|
|
|||
| isStateReady(id) { | |||
There was a problem hiding this comment.
This is quite nice but I feel like we now need to doc what string values are acceptable to it. How about defining some constants on the GroupStore class and and using these instead?
added 3 commits
October 31, 2017 14:21
…g/matrix-react-sdk into luke/groups-expose-ready-state
dbkr
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a
readyflag assigned to each fetching API used by the GroupServer. I've avoided making this generic for now for want of not doing so early.fixes element-hq/element-web#5457