Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Textarea based composer input #1561

Closed
wants to merge 1 commit into from
Closed

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 31, 2017

Fixes element-hq/element-web#4861
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@ara4n
Copy link
Member

ara4n commented Nov 3, 2017

I'm worried that the maintenance burden of the overlapping functionality between the draft & textarea-based composer is going to be a pain - I was expecting more to be factored out between the two, particularly: typing notifs, history management, clipboard pasting, processing slash commands. Otherwise the two are just going to spend their lives drifting out of sync with one another.

It otherwise looks good though :)

@dbkr
Copy link
Member

dbkr commented Jan 4, 2018

Echoing what @ara4n says about code duplication - I think this will be too much of a burden without factoring out the common functionality.

@lukebarnard1
Copy link
Contributor

@t3chguy are you likely to have another crack at doing this in a way that factors out functionality between both composers?

@lukebarnard1
Copy link
Contributor

FTR this looks like it will be usurped by move to Slate from Draft.js anyway.

@t3chguy
Copy link
Member Author

t3chguy commented May 23, 2018

I don't think this is superseded but will definitely be broken by;
Draft.js and Slate both use a contenteditable div which doesn't play very well with extensions which people like to use in their browsers to improve their editing experience, and other fun stuff like pop-out editors, which is why this PR was even a thing.

@lukebarnard1
Copy link
Contributor

Fair enough, @t3chguy. "Usurped" was probably the wrong word, my bad.

I can see us definitely wanting to support an "insert your favourite editor here" functionality, even with Slate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants