Room notifs in autocomplete & composer #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebarnard1
suggested changes
Nov 6, 2017
| import {PillCompletion} from './Components'; | ||
| import sdk from '../index'; | ||
|
|
||
| const AT_ROOM_REGEX = /@\S*/g; |
There was a problem hiding this comment.
I guess this means that users starting with the first part (of any length) of @room will be slightly more difficult to mention?
There was a problem hiding this comment.
Yeah, but not sure what we can do about this short of changing it to *room or something
There was a problem hiding this comment.
Well we could make it /@room/, mandating an entire match, so you'd have to type the whole shebang and then press tab
There was a problem hiding this comment.
That would still cause problems for people like late-noughties hitmakers @room5.
| @@ -58,6 +58,9 @@ const TYPING_USER_TIMEOUT = 10000, TYPING_SERVER_TIMEOUT = 30000; | |||
|
|
|||
| const ZWS_CODE = 8203; | |||
| const ZWS = String.fromCharCode(ZWS_CODE); // zero width space | |||
|
|
|||
| const ATROOMPILL_ENTITY_TYPE = 'ATROOMPILL'; | |||
There was a problem hiding this comment.
Maybe
const ENTITY_TYPES = {
AT_ROOM_PILL: 'AT_ROOM_PILL'
};
lukebarnard1
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A picture paints a thousand words...
We should probably remove the max-width here?
Requires element-hq/element-web#5531