Use the getProfileInfo API for group inviter profile #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebarnard1
added a commit
to element-hq/element-web
that referenced
this pull request
Nov 7, 2017
Part of showing the group inviter profile: matrix-org/matrix-react-sdk#1585
ara4n
reviewed
Nov 7, 2017
|
|
||
| let inviterName = group.inviter.userId; | ||
| if(this.state.inviterProfile) { | ||
| inviterName = this.state.inviterProfile.displayName || group.inviter.userId; |
There was a problem hiding this comment.
if the profile request fails for some reason shouldn't we fall back to mxid? (also, whitespace between if and ( ideally).
There was a problem hiding this comment.
if it did fail, this.state.inviterProfile will not have been set, and inviterName will be set to group.inviter.userId
|
lgtm other than minor nit and conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#5357