Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for sticker picker position #1903

Merged
merged 2 commits into from May 14, 2018

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented May 14, 2018

The better fixes are to:

  • Use relative positioning so that the browser worries more about context menu positioning than we do. We also get correct positioning after a resize for free
  • Implement a context menu that doesn't fall off the screen.

when the RightPanel is collapsed on a small monitor
and the sticker picker is opened.
@lukebarnard1 lukebarnard1 changed the base branch from develop to release-v0.12.4 May 14, 2018 16:16
@dbkr dbkr merged commit ab8f0ed into release-v0.12.4 May 14, 2018
lukebarnard1 added a commit that referenced this pull request Jun 12, 2018
This fixes element-hq/element-web#3429 in the case
of RoomList context menus *and* EventTile context menus.

This was mostly stolen from #1903 and it would be good to factor things
out at a later date such that #1903 is replaced with similar logic
within ContextualMenu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants