-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make RoomTooltip generic and add ContextMenu&Tooltip to GroupInviteTile #1950
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Could not have on same branch as dep as there is another PR depending on the same js-sdk PR |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM 👍
description: _t("Unable to reject invite"), | ||
}); | ||
} | ||
modal.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in a finally clause otherwise we'll get stuck with a spinner if an error is thrown in the catch.
group: this.props.group, | ||
onFinished: () => { | ||
this.setState({ menuDisplayed: false }); | ||
// this.props.refreshSubList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented code needs removal
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@lukebarnard1 sorry added a bit more, filtering of the Group Invite Tiles |
Those changes look totally unrelated. I suggest making a new PR in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
|
||
const GroupInviteTile = sdk.getComponent('groups.GroupInviteTile'); | ||
for (const group of MatrixClientPeg.get().getGroups()) { | ||
if (group.myMembership !== 'invite') continue; | ||
ret.push(<GroupInviteTile key={group.groupId} group={group} collapsed={this.props.collapsed} />); | ||
const {groupId: id, name, myMembership: membership} = group; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest keeping the variable names here; groupId
and myMembership
are fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed them when trying to squeeze it onto one line :P changed them back now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah :) thanks
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Requires matrix-org/matrix-js-sdk#656Fixes element-hq/element-web#6860
Fixes element-hq/element-web#5918
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com