prettyprint conference joins and parts properly #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
ara4n
added a commit
that referenced
this pull request
Mar 13, 2016
prettyprint conference joins and parts properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettify the horrible conf user join/parts at last: element-hq/element-web#174.
This is a slightly naughty way of doing it by inspecting CallHandler - i think the alternative would be to put the ConferenceHandler into MatrixChat's context and propagate it everywhere like that. I started doing that before realising this is easier (mainly because I needed to get at the ConferenceHandler from statics, which won't work with context). That experimental branch ended up at https://github.com/matrix-org/matrix-react-sdk/tree/matthew/confhandler fwiw.