Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle InvalidStoreError from js-sdk #2205

Merged
merged 2 commits into from Oct 10, 2018

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Oct 10, 2018

js-sdk now emits sync state ERROR with an InvalidStoreError if the
store needs to be cleared before it can be used.

Requires matrix-org/matrix-js-sdk#759

js-sdk now emits sync state ERROR with an InvalidStoreError if the
store needs to be cleared before it can be used.

Requires matrix-org/matrix-js-sdk#759
@dbkr dbkr requested a review from a team October 10, 2018 16:08
@@ -1419,6 +1422,42 @@ export default React.createClass({
}
},

_handleSyncError(e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover? Seems identical to Lifecycle.handleInvalidStoreError and not used AFAICT

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yep

@bwindels bwindels merged commit bba04a6 into develop Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants