Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign: resizeable/collapsible sections #2210

Merged
merged 28 commits into from
Oct 19, 2018
Merged

Redesign: resizeable/collapsible sections #2210

merged 28 commits into from
Oct 19, 2018

Commits on Sep 24, 2018

  1. make left panel adapt to width 

    includes using flexbox in the room tile to avoid hardcoded width
    @bwindels
    bwindels committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    313956d View commit details
    Browse the repository at this point in the history

  2. add resize handles between 3 main app columns

    @bwindels
    bwindels committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    928b6d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. make resize handles have correct color + bidirectional cursor

    @bwindels
    bwindels committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    e5d1b33 View commit details
    Browse the repository at this point in the history

  2. make the left panel collapse by only adding collapse class on container 

    as the resize handle is a sibling of the mxLeftPanel_container, that
class is the one that has to collapse if we don't want to complicate
the logic. So change style rules to check
.mxLeftPanel_container.collapsed, and make left panel not break
out of the container when it gets narrow by hiding the overflow
    @bwindels
    bwindels committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    d6774fd View commit details
    Browse the repository at this point in the history

  3. collapse left panel when 50px past min-width

    @bwindels
    bwindels committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    4f006b0 View commit details
    Browse the repository at this point in the history

  4. put sizing of right panel in RightPanel style file, plus min-width

    @bwindels
    bwindels committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    3331a29 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. Merge branch 'bwindels/redesign' into bwindels/resizehandles

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    01471ab View commit details
    Browse the repository at this point in the history

  2. dont base collapse toggle size on min-width, as it's not available in… 

    … collapsed state
    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    c56975d View commit details
    Browse the repository at this point in the history

  3. put dm icon back in it's correct location

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    99bf6b0 View commit details
    Browse the repository at this point in the history

  4. don't always show badge (leftover)

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    cc29dd0 View commit details
    Browse the repository at this point in the history

  5. align badge and make it non-flex when collapsed

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    8fa22d6 View commit details
    Browse the repository at this point in the history

  6. group collapsed styles

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    529845d View commit details
    Browse the repository at this point in the history

  7. provide collapsed callback to also collapse on react side of things

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    c095e30 View commit details
    Browse the repository at this point in the history

  8. turn resizer into class to make programmatic interaction/cleanup easier

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    30003d8 View commit details
    Browse the repository at this point in the history

  9. don't expose direction, handleIndex to distributor ctor

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    650e19f View commit details
    Browse the repository at this point in the history

  10. support programmatic access to a distributor (to set size from storage)

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    bb184a4 View commit details
    Browse the repository at this point in the history

  11. make it work for now, probably want to rename this back later on

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    1d2e1d4 View commit details
    Browse the repository at this point in the history

  12. onResized callback

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    28ec0f7 View commit details
    Browse the repository at this point in the history

  13. only fire onCollapsed once when changing

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    3a26f0f View commit details
    Browse the repository at this point in the history

  14. store/load lhs & rhs sizes to/from localStorage

    @bwindels
    bwindels committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    110e452 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. add copyright headers

    @bwindels
    bwindels committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    6fdcebb View commit details
    Browse the repository at this point in the history

  2. fix lint

    @bwindels
    bwindels committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    8d3347b View commit details
    Browse the repository at this point in the history

  3. add some description to some classes

    @bwindels
    bwindels committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    d8ead8a View commit details
    Browse the repository at this point in the history

  4. more docs

    @bwindels
    bwindels committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    8d414d0 View commit details
    Browse the repository at this point in the history

  5. remove .collapsed class on mx_LeftPanel as the container already has it

    @bwindels
    bwindels committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    c926aa2 View commit details
    Browse the repository at this point in the history

  6. more lint fixes

    @bwindels
    bwindels committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    3552326 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. bind instead of second member var

    @bwindels
    bwindels committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    eb1ee1c View commit details
    Browse the repository at this point in the history

  2. dont cause rerender with anon func

    @bwindels
    bwindels committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    7ece134 View commit details
    Browse the repository at this point in the history