Redesign: move right panel below room/group header #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to put a resize handle between the body and the right panel later on
this breaks user view for now but this is not available through any UI as it is, and we don't know yet what this will look like in the new design, even if it will be a feature at all.
|
Push hook is failing because disabling e2e test didn't work there, see #2261 |
|
Green! ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓ |
dbkr
reviewed
Nov 2, 2018
| <div className="mx_RoomView_statusAreaBox_line"></div> | ||
| { statusBar } | ||
| <MainSplit panel={rightPanel} collapsedRhs={this.props.collapsedRhs}> | ||
| <div className={fadableSectionClasses}> |
There was a problem hiding this comment.
Have we lost the <main> / <aside>? Would be good to keep these as they help a11y.
There was a problem hiding this comment.
Right. Added it back, but as the root of the group/room view, so the <aside> is now inside the <main>. Before it was a sibling of of <main>, but having it as a child seems to be the defined semantics.
dbkr
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element-hq/element-web#7556