Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Optimize Webpack Performance and bundle size #2323

Closed
wants to merge 6 commits into from
Closed

[DO NOT MERGE] Optimize Webpack Performance and bundle size #2323

wants to merge 6 commits into from

Conversation

MTRNord
Copy link
Contributor

@MTRNord MTRNord commented Dec 4, 2018

This commit does what I explained in element-hq/element-web#7391

It is paired with element-hq/element-web#7772

Signed-off-by: Marcel Radzio <mtrnord1 [at] gmail.com>

TODO

  • Make reskindex dynamicly decide if it should use src or lib instead of hardcoding (to not break babel react-sdk builds)
  • Dont change the package.json main field but instead overwrite it in riot-web using webpack

@MTRNord
Copy link
Contributor Author

MTRNord commented Dec 4, 2018

Investiganting why the build fails curently (It worked while testing but thats a few commits ago)

@bwindels
Copy link
Contributor

(just make it clear this isn't ready yet, in addition to the WIP prefix)

@MTRNord MTRNord changed the title [WIP] Optmize Webpack Performance and bundle size Optmize Webpack Performance and bundle size Dec 27, 2018
@MTRNord
Copy link
Contributor Author

MTRNord commented Dec 27, 2018

Tests are failing because it fails to resolve the correct compainion branch. Please test it locally first before merging.

@MTRNord
Copy link
Contributor Author

MTRNord commented Dec 27, 2018

@bwindels the notready tag can be removed as it isn't WIP anymore

@MTRNord
Copy link
Contributor Author

MTRNord commented Feb 27, 2019

Rebased to new develop

@jryans jryans changed the title Optmize Webpack Performance and bundle size Optimize Webpack Performance and bundle size Mar 7, 2019
…nly use "src" in the component-index if "matrix-react-build-type" is "webpack"

Signed-off-by: MTRNord <mtrnord1@gmail.com>

Took 6 minutes
…x.js instead of lib/index.js

Took 14 minutes
@MTRNord MTRNord closed this Mar 20, 2019
@MTRNord MTRNord reopened this Mar 21, 2019
@MTRNord MTRNord changed the title Optimize Webpack Performance and bundle size [DO NOT MERGE] Optimize Webpack Performance and bundle size Mar 21, 2019
@MTRNord MTRNord closed this Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants