Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour, contrast & legibility improvements #2378

Merged
merged 6 commits into from
Dec 20, 2018

Conversation

nadonomy
Copy link
Contributor

@nadonomy nadonomy commented Dec 20, 2018

Improved colour, contrast and legibility of the left panel/room list and use of colour all round. More specifically, this PR actions:

element-hq/element-web#7892
element-hq/element-web#7887
element-hq/element-web#7881
element-hq/element-web#7891
element-hq/element-web#7885

During development, I lost confidence in #7891 making sense anymore while using the app with all these changes in chorus. I've left it in, to dogfood, and we can just revert commit 9b8f07c if need be.

Looks like:

Unreads

Before:
screenshot 2018-12-20 at 11 40 06
After :
screenshot 2018-12-20 at 11 27 46

Unreads and Mentions

Before:
screenshot 2018-12-20 at 11 40 32
After :
screenshot 2018-12-20 at 11 28 10

Contextual colours

Before:
screenshot 2018-12-20 at 12 51 58

After :
screenshot 2018-12-20 at 12 42 31

@nadonomy nadonomy requested a review from a team December 20, 2018 12:53
@jryans jryans self-assigned this Dec 20, 2018
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nad, this looks great! 😁

There is a CI failure, but it seems like a known issue on experimental, so safe to merge.

@jryans jryans assigned nadonomy and unassigned jryans Dec 20, 2018
@jryans jryans merged commit 95c739b into experimental Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants