Remove 'welcome' from top-left menu #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tjis is quite confusing as the welcome page is designed for when you're not logged in, ie. has a sign-in button. There's also no way to get back into the app so it really looks like it's logged you out. Reverts 116367f
jryans
approved these changes
Feb 14, 2019
| @@ -25,8 +25,6 @@ import MatrixClientPeg from '../../../MatrixClientPeg'; | |||
| export class TopLeftMenu extends React.Component { | |||
| constructor() { | |||
| super(); | |||
| this.viewHomePage = this.viewHomePage.bind(this); | |||
There was a problem hiding this comment.
The viewHomePage line is a related bug fix that I think we want to keep. (I should have made a separate commit...)
|
oops, well spotted - I was trying to minimise chances of me screwing it up by just reverting the commit but I didn't spot that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tjis is quite confusing as the welcome page is designed for when
you're not logged in, ie. has a sign-in button. There's also no way
to get back into the app so it really looks like it's logged you
out.
Reverts 116367f
Fixes element-hq/element-web#8618